T_NULLABLE detection not working for nullable parameters and return type hints in some cases #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
May 8, 2017
…eters and return type hints in some cases
gsherwood
added a commit
that referenced
this pull request
May 9, 2017
…eters and return type hints in some cases
|
Thanks for the bug report, although I decided to code this in a slightly different way to avoid the extra loops and lines of code. I've committed a fix for versions 2 and 3, but I'm definitely not going to release without leaving the fixes in place for a while. |
|
Could you please release fix versions? This is blocker for long line of packages that depend on this. |
|
Thank you @gsherwood and @kukulich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 46983c7 broke T_NULLABLE detection. This should fix it and #1421 should still be fixed too.
The pull request is based on 2.9 branch however it's very easy to port this bugfix to 3.0 branch. You just have to change
PHP_CodeSniffer_Tokens::$emptyTokenstoUtils\Tokens::$emptyTokens.It would be very nice if you could release versions 2.9.1 and 3.0.1 very quickly. Actually both versions are unusable for users that use nullable parameter and return type hints.