bblfsh: temporarily use aliases on some language names #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #728 Until bblfsh lands support for aliases on all its methods, there is no way of using certaing languages easily in gitbase, such as C# or C++/C. By adding these aliases, it can be used until it's fixed on bblfsh's side. Signed-off-by: Miguel Molina <[email protected]>
|
maybe it's better to implement this workaround on bblfsh side? it would fix engine, gemini, jgit-spark-connector, gitbase-spark-connector. Not only gitbase. |
|
I think it should be supported by enry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728
Until bblfsh lands support for aliases on all its methods, there
is no way of using certaing languages easily in gitbase, such as
C# or C++/C. By adding these aliases, it can be used until it's
fixed on bblfsh's side.