Update to golangci-lint 1.8.1. Get rid of standalong misspell linter. #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
approved these changes
Jun 29, 2018
|
Hi! |
|
That's great to hear, @jirfag! I'm even happier now to have switched to |
gravityblast
approved these changes
Jul 2, 2018
|
Simplified this PR with the awesome help from @jirfag doing a quick 1.9.1 release. Merging once build finishes. |
pedropombeiro
force-pushed
the
feature/update-lint-1.8.1
branch
from
4497c2f to
0071787
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
govetis complaining about missinglib/Candsignal/Cfolders. The workaround here was to ignore any subfolders of those 2 folders, but alternatively we could run the linter once for govet (without those folders) and a second time for the rest (although we'd lose some performance gains by doing that).