-
Notifications
You must be signed in to change notification settings - Fork 997
Display .eth or other domain rather than IPFS redirect #6169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The eventual website path should be displayed too. We might want to display associate hash after a long press on the bar. @denis-sharypin Could you provide some design guidance? |
@jeluard , @rachelhamlin I had this in mind. wdyt? |
@denis-sharypin Looks great! Can you make sure only the website path is visible? i.e. no |
@jeluard why did we want only the path to be visible? Did you mean to have the path following |
@rachelhamlin In case of a website hosted on IPFS there is no real URL. The one we have right now (infura based) and kind of implementation details and I don't think we should show it. So the only interesting part left is the current path the user is navigating (that's |
After discussing this in Status, I think that if we want to display file paths, it should come after the ENS name. For example: |
Curious: what happens when I interact with the browser bar in this mockup? It has two lines. Which text am I editing when I tap it? Should there be some animation to minimize one line? |
let's make it simple, show only ens, and if you click on it show full url |
That works @flexsurfer! |
@rachelhamlin |
Gotcha @flexsurfer so we can only handle domains that the browser redirects, aka ENS addresses? |
Signed-off-by: Andrey Shovkoplyas <[email protected]>
…ightmode (#21865) Upgrades status-go to version v8.0.0, which includes the fix from PR status-im/status-go#5964 fix_: bad peer check logic for lightmode and some fixes. Might resolve #18031 Areas that may be impacted: we are moving from status-go version 7.0.0 to 8.0.0. These are the changes: - status-im/status-go@a4e36d49c * fix_: missing message verifier start-stop ,go-waku updates, lightpush service rate limits (#5964) - status-im/status-go@810468a57 * test_: create private group tests (#6225) - status-im/status-go@0cf556bdb * test_: unskip test initialize logging (#6229) - status-im/status-go@b803918c2 * ci_: pytest-lint correct target pr branch (#6230) - status-im/status-go@d29120447 * chore(block)!: remove desktop BlockContact function for parity (#6172) - status-im/status-go@309d17ae5 * feat_: status-backend health endpoint (#6201) - status-im/status-go@6a5623bac * test_: set proxy creds (#6211) - status-im/status-go@2172abe95 * fix_: add infuraSecret and statusProxyBlockchainPassword to secrets (#6217) - status-im/status-go@0f7c26dc9 * test_: skip flaky TestService_IncrementalUpdateMixed (#6205) - status-im/status-go@75bdda271 * fix_: correct sensitive regex (#6188) - status-im/status-go@08eee8a64 * test_: add python linters (#6212) - status-im/status-go@66850321e * fix_: remove logging of rpc endpoint (#6195) - status-im/status-go@c27c773c2 * chore(wallet)_: from and to chains added to send details - status-im/status-go@74db63143 * test_: contact requests tests (#6167) - status-im/status-go@5a8310d5a * fix(pins)_: delete pins when the og message is deleted (#6173) - status-im/status-go@137698e02 * ci_: bring back cmd coverage (#6204) - status-im/status-go@1795620df * test_: run functional tests on host (no container) (#6159) - status-im/status-go@ef177c1c6 * feat_: SensitiveString type (#6190) - status-im/status-go@8b95c8148 * feat_: graceful shutdown with status-backend (#6189) - status-im/status-go@e6c2f89f0 * chore_: remove endpoint InitLogging (#6182) - status-im/status-go@4ccb08f11 * test_: WalletService class (#6171) - status-im/status-go@943ae1335 * fix(functional-tests)_: disable testnet (#6181) - status-im/status-go@616a76098 * feat_: api logging signals (#6150) - status-im/status-go@dfb591874 * fix_: check group error in GetBalancesAtByChain (#6169) - status-im/status-go@3a0080281 * fix_: create/restore account error signal (#6174) - status-im/status-go@e7cc53529 * feat(telem)_: track total waku message bandwidth (#6157) - status-im/status-go@d07e61f61 * fix_: nil *MessengerResponse is a valid result (#6175))
User Story
As a user, I want to receive permission requests from a specific URL—not
ipfs.infura
—so that I am aware of who is requesting my data.Description
Type: Feature
Summary: Rather than displaying a hash for IPFS-hosted DApps in the browser, keep the human readable format of the redirected domain.
Expected behavior
Instead of
https://ipfs.infura.io/ipfs/QmYhTGg88WvJh9K86m3JYow3QxdXMkgk8stkTDqy87joZn/
, for example, I would seestatusnames.eth
in the URL bar. Any requests from this DApp would come fromstatusnames
(if not a default DApp in Status).Actual behavior
Currently, the browser displays the IPFS hash a domain is redirected to, and this in turn is used when the DApp requests user permissions for something.
Reproduction
Navigate to
vote.status.im
in any browser.The text was updated successfully, but these errors were encountered: