Upgrade shadow-cljs and ClojureScript #15417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilmotta
requested review from
alwx,
erikseppanen,
cammellos,
jakubgs,
rasom,
vkjr,
flexsurfer,
yqrashawn,
Parveshdhull,
briansztamfater,
J-Son89,
OmarBasem,
ibrkhalil,
siddarthkay and
ulisesmac
ilmotta
commented
Mar 21, 2023
| options) | ||
| callback)) | ||
| [value] | ||
| (reanimated/with-spring value |
There was a problem hiding this comment.
FYI: The newer ClojureScript version throws a runtime error when the original function signature is used. I just removed the extra arguments, since they were never used in the first place.
Jenkins BuildsClick to see older builds (19)
|
siddarthkay
reviewed
Mar 21, 2023
siddarthkay
approved these changes
Mar 21, 2023
OmarBasem
approved these changes
Mar 21, 2023
yqrashawn
approved these changes
Mar 21, 2023
flexsurfer
reviewed
Mar 21, 2023
alwx
approved these changes
Mar 21, 2023
jakubgs
approved these changes
Mar 21, 2023
J-Son89
approved these changes
Mar 21, 2023
|
Cool! I'm glad we'll have |
vkjr
approved these changes
Mar 21, 2023
|
Hey folks, I re-requested your reviews and resurrected this PR (thanks @OmarBasem) because I could upgrade Shadow CLJS and ClojureScript to their latest versions after the amazing work done in the mobile team to upgrade RN 🚀 I haven't seen any issues in my tests with Android with and without Hermes and in dev or release builds. If you can, please report back if you tested on iOS and everything is good. That way we can quickly merge this PR. Thank you! 💟 |
siddarthkay
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Great work @ilmotta!
I tested the PR build on my iPhone 11 and it works fine!
yqrashawn
approved these changes
Jul 28, 2023
alwx
approved these changes
Jul 28, 2023
smohamedjavid
approved these changes
Jul 28, 2023
|
Thanks for your amazing work! Devices:
|
|
Oh @churik, thank you so much, I was going to move the PR to the e2e column but forgot in the myriad of things going on today. Great news, I want this PR to be merged real bad ;) |
------ WARNING #1 - :redef ----------------------------------------------------- Resource: taoensso/encore.cljs:947:1 -------------------------------------------------------------------------------- 944 | ) 945 | 946 | (defn pow [n exp] (Math/pow n exp)) 947 | (defn abs [n] (if (neg? n) (- n) n)) ; #+clj (Math/abs n) reflects -------^------------------------------------------------------------------------ abs already refers to: cljs.core/abs being replaced by: taoensso.encore/abs -------------------------------------------------------------------------------- 948 | (defn round* ; round 949 | ([ n] (round* :round nil n)) 950 | ([type n] (round* type nil n)) 951 | ([type nplaces n] --------------------------------------------------------------------------------
ilmotta
force-pushed
the
chore/upgrade-shadow-cljs
branch
from
d71b63a to
a32d6d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades shadow-cljs from
2.11.16(released on 2021-02-03) to2.19.6(released on 2022-07-14), so ~1.5 years worth of upgrades. By upgrading shadow-cljs we can finally use the latest major Clojure version1.11.Why upgrade shadow-cljs?
Shadow-cljs controls the ClojureScript version we can use. In order to use the latest major Clojure version (
1.11.x) we need to upgrade shadow-cljs.Shadow-cljs releases new versions very frequently, and if you take a look at its changelog, you'll see it had tons and tons of bug fixes over the years. I hope some of them help improve the DX for certain contributors who recently reported issues with shadow-cljs. It might make things worse though, we never know.
Clojure 1.11 brings new features, bug fixes and even performance improvements (although I think the performance mostly impacts Clojure on the JVM). See the changelog https://github.com/clojure/clojure/blob/master/changes.md#changes-to-clojure-in-version-1110
Things that can be beneficial to us, or are interesting nonetheless:
:as-aliasto be used inrequire, which is like:asbut does not require the namespace to load. This means namespaced keywords using:as-aliascan't cause circular dependency errors. This feature would very useful if we used namespaced keywords, but we don't, so... https://github.com/clojure/clojure/blob/master/changes.md#22-as-alias-in-requirerun-testandrun-test-varto run single test with fixtures and report.iterationfunction, useful for processing paginated data. https://www.abhinavomprakash.com/posts/clojure-iteration/update-keysfunction: applies a function to every key in a map.update-valsfunction: applies a function to every value in a map.Examples for
update-valsandupdate-keys. They should perform better than the commonreduce-kvapproach since they use a transient data structure.Why change namespaces within
__tests__directories?Any namespace with the word
--tests--throws an error, like the one below. I didn't bother investigating why, so I changed the guidelines to reflect the new convention. It's probably related to the double dashes in the name 🤷♂️Why can't we upgrade to the most recent shadow-cljs version?
We can't go to versions newer than
2.19.6because we're stuck with the very old OpenJDK 8, and some new code from shadow-cljs2.19.7+requires at least OpenJDK 11.Review notes
Please, review this PR by running the app as you usually do, especially if you have access to macOS, since I don't have one at hand.
Steps to test
Things I tested:
encorelib).status: ready