Skip to content

[RFC]: add @stdlib/assert/is-negative-finite #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kgryte opened this issue Feb 22, 2024 · 7 comments · Fixed by #1356
Closed
3 tasks done

[RFC]: add @stdlib/assert/is-negative-finite #1345

kgryte opened this issue Feb 22, 2024 · 7 comments · Fixed by #1356
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 22, 2024

Description

This RFC proposes adding the package @stdlib/assert/is-negative-finite.

The package should be similar in structure to @stdlib/assert/is-negative-number and should have a similar implementation except negative infinity should evaluate to false.

function isNegativeFinite( value ) { ... }

Package: @stdlib/assert/is-negative-finite
Alias: isNegativeFinite

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 22, 2024
@adityacodes30

This comment was marked as outdated.

Sign in to view
@Planeshifter

This comment was marked as outdated.

Sign in to view
@kgryte

This comment was marked as outdated.

Sign in to view
@gunjjoshi
Copy link
Member

gunjjoshi commented Feb 23, 2024 •
edited
Loading

Can you please assign this to me ? I have understood the project structure.

@kgryte
Copy link
Member Author

kgryte commented Feb 23, 2024

Thank you for volunteering to work on this @gunjjoshi. Please feel free to submit a PR implementing this feature.

@kgryte kgryte added Accepted RFC feature request which has been accepted. priority: Low Low priority concern or feature request. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Utilities Issue or pull request concerning general utilities. JavaScript Issue involves or relates to JavaScript. labels Feb 23, 2024
@adityacodes30
Copy link
Contributor

alright , no problem at all @kgryte took this one up as well because it seemed quite similar to #1346 which i am implementing

@gunjjoshi let me know if you need any help

@gunjjoshi
Copy link
Member

Thanks @adityacodes30, for now I am almost done with this one, will be making a PR in a while.

@gunjjoshi gunjjoshi mentioned this issue Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added assert/is-negative-finite
4 participants
@Planeshifter @kgryte @gunjjoshi @adityacodes30