Skip to content

[RFC]: add @stdlib/assert/is-positive-finite #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kgryte opened this issue Feb 22, 2024 · 2 comments · Fixed by #1358
Closed
3 tasks done

[RFC]: add @stdlib/assert/is-positive-finite #1346

kgryte opened this issue Feb 22, 2024 · 2 comments · Fixed by #1358
Assignees
@adityacodes30
Labels
Accepted RFC feature request which has been accepted. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 22, 2024

Description

This RFC proposes adding the package @stdlib/assert/is-positive-finite.

The package should be similar in structure to @stdlib/assert/is-positive-number and should have a similar implementation except positive infinity should evaluate to false.

function isPositiveFinite( value ) { ... }

Package: @stdlib/assert/is-positive-finite
Alias: isPositiveFinite

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 22, 2024
@adityacodes30
Copy link
Contributor

i will take this up , please assign

@kgryte
Copy link
Member Author

kgryte commented Feb 22, 2024

Thanks for volunteering to implement this feature, @adityacodes30. Please feel free to submit a PR with an implementation.

@adityacodes30 adityacodes30 mentioned this issue Feb 22, 2024
Closed
3 tasks
adityacodes30 added a commit to adityacodes30/stdlib that referenced this issue Feb 23, 2024
@adityacodes30
feat(@stdlib/assert): add isPositiveFinite function,in Progress,stdli…
d63b9dd 
…b-js#1346
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. priority: Low Low priority concern or feature request. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. labels Feb 23, 2024
adityacodes30 added a commit to adityacodes30/stdlib that referenced this issue Feb 23, 2024
@adityacodes30
feat(@stdlib/assert): add isPositiveFinite function,implemented,closes …
dc075eb 
…stdlib-js#1346
@adityacodes30 adityacodes30 mentioned this issue Feb 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adityacodes30 adityacodes30

Labels
Accepted RFC feature request which has been accepted. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements is-positive finite adityacodes30/stdlib
2 participants
@kgryte @adityacodes30