Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/ahaversin #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Pranavchiku opened this issue Feb 29, 2024 · 8 comments · Fixed by #1840
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/ahaversin #1420

Pranavchiku opened this issue Feb 29, 2024 · 8 comments · Fixed by #1840
Assignees
@Rejoan-Sardar
Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Description

This RFC proposes adding native C implementation for @stdlib/math/base/special/ahaversin.

double stdlib_base_ahaversin( const double x );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 29, 2024
@Rejoan-Sardar
Copy link
Contributor

I would like to work on this issue, please assign.

@Pranavchiku
Copy link
Member Author

Go ahead, assigned it to you.

@Shashankss1205
Copy link
Contributor

I have completely understood the issue,
Kindly assign it to me, if no PR is made.

@Pranavchiku
Copy link
Member Author

@Shashankss1205 let @Rejoan-Sardar try and if is unable you may proceed, till then you can check #1433 if you wish

@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 3, 2024
Closed
1 task
@Shashankss1205
Copy link
Contributor

@Pranavchiku If the Issue is still pending to be resolved, I am more than happy to work on it.

@Rejoan-Sardar
Copy link
Contributor

almost done with it bro , I will update my PR

@Pranavchiku
Copy link
Member Author

@Shashankss1205 there are other good first issues you may look at. Also, we'll prefer to have #1670, and #1671 merged before you work on other PRs.

@Shashankss1205
Copy link
Contributor

Okay @Pranavchiku , I would wait for those 2 PRs to get merged, uptill then I'll take a look over the Machine Learning packages , because that's my favourite domain.

This was referenced Mar 6, 2024
Closed
Merged
Planeshifter pushed a commit that referenced this issue Mar 12, 2024
@Rejoan-Sardar @Pranavchiku
feat: add C implementation for math/base/special/ahaversin
3addfa7 
PR-URL: #1840
Closes: #1420

---------

Signed-off-by: Rejoan Sardar <[email protected]>
Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rejoan-Sardar Rejoan-Sardar

Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
3 participants
@Pranavchiku @Rejoan-Sardar @Shashankss1205