Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/max #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Pranavchiku opened this issue Mar 1, 2024 · 4 comments · Fixed by #1459
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/max #1433

Pranavchiku opened this issue Mar 1, 2024 · 4 comments · Fixed by #1459
Assignees
@Shashankss1205
Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Description

This RFC proposes adding native C implementation for @stdlib/math/base/special/max.

double stdlib_base_max( const double x, const double y );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 1, 2024
@Pranavchiku Pranavchiku mentioned this issue Mar 1, 2024
Closed
3 tasks
@Shashankss1205
Copy link
Contributor

Please assign it to me @Pranavchiku , as my previous PR has been made.

@Ccivam
Copy link

Ccivam commented Mar 1, 2024 •
edited
Loading

@Pranavchiku I have understood the issue.Can you please assign it to me

@rajutkarsh07
Copy link
Contributor

@Planeshifter @kgryte I have understood this issue, I would like to work on it Please assign this to me

@aman-095 aman-095 mentioned this issue Mar 2, 2024
Merged
1 task
@Shashankss1205 Shashankss1205 mentioned this issue Mar 2, 2024
Merged
1 task
@Shashankss1205
Copy link
Contributor

I have added the PR #1459 for this Issue. Kindly review it @Pranavchiku

@Pranavchiku Pranavchiku mentioned this issue Mar 3, 2024
Closed
3 tasks
This was referenced Mar 9, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shashankss1205 Shashankss1205

Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add C implementation for math/base/special/max Shashankss1205/stdlib
4 participants
@rajutkarsh07 @Pranavchiku @Ccivam @Shashankss1205