Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/maxabs #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Shashankss1205 opened this issue Mar 2, 2024 · 9 comments · Fixed by #1671
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/maxabs #1460

Shashankss1205 opened this issue Mar 2, 2024 · 9 comments · Fixed by #1671
Assignees
@Shashankss1205
Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request.

Comments

@Shashankss1205
Copy link
Contributor

Shashankss1205 commented Mar 2, 2024 •
edited by kgryte
Loading

Description

This RFC proposes adding native C implementation for @stdlib/math/base/special/maxabs.

double stdlib_base_maxabs( const double x, const double y );

Related Issues

Related issues #1433, #1449.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first issue! We will get back to you shortly. 🏃 💨

@Shashankss1205 Shashankss1205 changed the title [RFC]: Add C implementation for [@stdlib/math/base/special/maxabs] [RFC]: Add C implementation for @stdlib/math/base/special/maxabs Mar 2, 2024
@Pranavchiku
Copy link
Member

Pranavchiku commented Mar 3, 2024 •
edited
Loading

@Shashankss1205 can you please refer to #1449 and populate description well. Thanks for opening this. Also mark related issue as #1433.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 3, 2024
@rajutkarsh07
Copy link
Contributor

@Pranavchiku @Planeshifter @kgryte I have understood this issue, I want to work on it. So please assign this issue to me

@kgryte
Copy link
Member

kgryte commented Mar 3, 2024

@Shashankss1205 Are you planning on implementing this, given that you opened the issue?

@Shashankss1205
Copy link
Contributor Author

Yes I am already working on this @kgryte . Please assign it to me.

@Shashankss1205
Copy link
Contributor Author

@Shashankss1205 can you please refer to #1449 and populate description well. Thanks for opening this. Also mark related issue as #1433.

I didn't understand about "populating the description", I just kept it the way other similar issues were made. Please suggest the required changes that I should make.

@kgryte
Copy link
Member

kgryte commented Mar 3, 2024

@Shashankss1205 I've updated the OP.

@Shashankss1205
Copy link
Contributor Author

@Shashankss1205 I've updated the OP.

Thank you @kgryte for the guiding help.

@Shashankss1205 Shashankss1205 mentioned this issue Mar 3, 2024
Closed
1 task
@Shashankss1205
Copy link
Contributor Author

Please Review the PR and suggest the needful changes @kgryte .

@Shashankss1205 Shashankss1205 mentioned this issue Mar 3, 2024
Merged
1 task
Planeshifter pushed a commit that referenced this issue Mar 11, 2024
@Shashankss1205 @Pranavchiku
feat: add C implementation for math/base/special/maxabs
fa68dfe 
PR-URL:  #1671
Closes: #1460

---------

Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shashankss1205 Shashankss1205

Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request.
Projects
None yet
Milestone
No milestone
5 participants
@kgryte @rajutkarsh07 @stdlib-bot @Pranavchiku @Shashankss1205