Skip to content

[RFC]: refactor blas/ext/base/dnannsumkbn2 to follow current project conventions #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #2063
Closed
3 tasks done

[RFC]: refactor blas/ext/base/dnannsumkbn2 to follow current project conventions #1480

Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #2063
Assignees
@vr-varad
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/dnannsumkbn2 to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@vr-varad
Copy link
Contributor

@Planeshifter As this issue is related to my last issue I would like to work on this.
could u please assign it to me?

@Planeshifter
Copy link
Member Author

@vr-varad Done. Looking forward to the PR. 🚀

@vr-varad vr-varad mentioned this issue Mar 27, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Apr 22, 2024
@vr-varad @Planeshifter
refactor: update blas/ext/base/dnannsumkbn2 to follow current proje…
0f07a02 
…ct conventions

PR-URL: #2063
Closes: #1480 
Ref: #1152

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vr-varad vr-varad

Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/dnannsumkbn2 to follow current project…
2 participants
@Planeshifter @vr-varad