Skip to content

[RFC]: refactor blas/ext/base/sfill to follow current project conventions #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #1809
Closed
3 tasks done

[RFC]: refactor blas/ext/base/sfill to follow current project conventions #1527

Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #1809
Assignees
@AgPriyanshu18
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/sfill to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@AgPriyanshu18
Copy link
Contributor

@kgryte @Planeshifter I would like to take this issue

@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Accepted RFC feature request which has been accepted. labels Mar 7, 2024
@kgryte
Copy link
Member

kgryte commented Mar 7, 2024

Thanks for volunteering to work on this, @AgPriyanshu18. Feel free to submit a PR implementing the requested changes.

AgPriyanshu18 added a commit to AgPriyanshu18/stdlib that referenced this issue Mar 9, 2024
@AgPriyanshu18
refactor: update blas/ext/base/sfill to follow current projects conve…
84fdfca 
…ntions

Updated the package to follow current projects conventions

Fixes stdlib-js#1527
@AgPriyanshu18 AgPriyanshu18 mentioned this issue Mar 9, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue Apr 17, 2024
@AgPriyanshu18 @kgryte
@Pranavchiku @Planeshifter
refactor: update blas/ext/base/sfill to follow current projects con…
a7f3e44 
…ventions

PR-URL: #1809
Closes:  #1527
Ref: #1152

---------

Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Pranav Goswami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgPriyanshu18 AgPriyanshu18

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/sfill to follow current projects conventions AgPriyanshu18/stdlib
3 participants
@Planeshifter @kgryte @AgPriyanshu18