Skip to content

refactor: update blas/ext/base/sfill to follow current projects conventions #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 17, 2024
Merged

refactor: update blas/ext/base/sfill to follow current projects conventions #1809

merged 7 commits into from
Apr 17, 2024

Conversation

AgPriyanshu18
Copy link
Contributor

@AgPriyanshu18 AgPriyanshu18 commented Mar 9, 2024 •
edited
Loading

Resolves #1527.

Description

What is the purpose of this pull request?

This pull request:

  • refactors blas/ext/base/sfill to follow current projects convention

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 10, 2024
@Planeshifter Planeshifter changed the title refactor: update blas/ext/base/sfill to follow current projects conve… refactor: update blas/ext/base/sfill to follow current projects conventions Mar 10, 2024
@AgPriyanshu18
refactor: update blas/ext/base/sfill to follow current projects conve…
84fdfca 
…ntions

Updated the package to follow current projects conventions

Fixes stdlib-js#1527
@kgryte
Copy link
Member

kgryte commented Mar 10, 2024

@AgPriyanshu18 Would you mind checking the box in the OP that you've read the contributing guidelines? We require this as an acknowledgment of licensing terms and attribution.

Pranavchiku
Pranavchiku suggested changes Mar 10, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested. Please avoid updating copyright year. Thanks @AgPriyanshu18 !

@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2024
@stdlib-js stdlib-js deleted a comment from Pranavchiku Mar 20, 2024
@kgryte @Pranavchiku
Apply suggestions from code review
dffbbf5 
Co-authored-by: Pranav <[email protected]>
Signed-off-by: Athan <[email protected]>
@stdlib-js stdlib-js deleted a comment from Pranavchiku Mar 20, 2024
kgryte
kgryte requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through and undone all the copyright year changes. This PR still needs further updates. Namely, the addon.c file needs to be updated and the manifest.json file needs to be updated.

@AgPriyanshu18 AgPriyanshu18 mentioned this pull request Mar 21, 2024
Closed
6 tasks
@kgryte kgryte added the Enhancement Issue or pull request for enhancing existing functionality. label Mar 22, 2024
@Planeshifter Planeshifter self-requested a review April 17, 2024 01:57
@Planeshifter Planeshifter merged commit a7f3e44 into stdlib-js:develop Apr 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

@Pranavchiku Pranavchiku Pranavchiku requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sfill to follow current project conventions
4 participants
@AgPriyanshu18 @kgryte @Planeshifter @Pranavchiku