Skip to content

[RFC]: refactor blas/ext/base/ssorthp to follow current project conventions #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 4 comments · Fixed by #1770
Closed
3 tasks done

[RFC]: refactor blas/ext/base/ssorthp to follow current project conventions #1537

Planeshifter opened this issue Mar 3, 2024 · 4 comments · Fixed by #1770
Assignees
@naveen1m
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/ssorthp to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@naveen1m
Copy link
Contributor

naveen1m commented Mar 6, 2024

@Planeshifter please assign this issue to me. I want to work on this issue.

@Planeshifter
Copy link
Member Author

@naveen1m great, thanks!

@naveen1m naveen1m mentioned this issue Mar 8, 2024
Merged
10 tasks
@naveen1m
Copy link
Contributor

I have done the required changes and now am trying to commit them but I am facing issues with the Linter, can you please help me with this error!
image
I would like to know about stdlib/doctest

@naveen1m
Copy link
Contributor

@Planeshifter please review my pr #1770

Planeshifter added a commit that referenced this issue Apr 27, 2024
@naveen1m @Planeshifter
refactor: update blas/ext/base/ssorthp to follow current project co…
726cca7 
…nventions

PR-URL: #1770
Closes: #1537 
Ref: #1152

---------

Co-authored-by: Praveen Kumar <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naveen1m naveen1m

Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/ssorthp to follow current project conventions naveen1m/stdlib
2 participants
@Planeshifter @naveen1m