Skip to content

[RFC]: Add C implementation for @stdlib/math/base/assert/is-odd #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Shashankss1205 opened this issue Mar 3, 2024 · 4 comments · Fixed by #1670
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/assert/is-odd #1668

Shashankss1205 opened this issue Mar 3, 2024 · 4 comments · Fixed by #1670
Assignees
@Shashankss1205
Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Shashankss1205
Copy link
Contributor

Description

This RFC proposes adding native C implementation for @stdlib/math/base/assert/is-odd 

double stdlib_base_is_odd( const double x )

Related Issues

No

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Shashankss1205
Copy link
Contributor Author

I would like to get it assigned to myself.

@Pranavchiku
Copy link
Member

@Shashankss1205 you'll have to wait till #1667 gets merged.

@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! labels Mar 3, 2024
@Pranavchiku
Copy link
Member

Pranavchiku commented Mar 3, 2024 •
edited
Loading

@Shashankss1205 feel free to work on this, refer #1667, and I will request you to be quick as this is blocker for #1656. Your volunteering is highly appreciated, thanks!

@Shashankss1205 Shashankss1205 mentioned this issue Mar 3, 2024
Closed
1 task
@Shashankss1205
Copy link
Contributor Author

Have made the PR for this issue, please review it @Pranavchiku

@Shashankss1205 Shashankss1205 mentioned this issue Mar 3, 2024
Merged
1 task
kgryte added a commit that referenced this issue Mar 5, 2024
@Shashankss1205 @kgryte @Pranavchiku
feat: add C implementation for math/base/assert/is-odd
f0684da 
Closes: #1668
PR-URL: 	#1670
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Signed-off-by: Pranav Goswami <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this issue Mar 7, 2024
@Shashankss1205 @kgryte @Pranavchiku
feat: add C implementation for math/base/assert/is-odd
33b4f70 
Closes: stdlib-js#1668
PR-URL: 	stdlib-js#1670
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Signed-off-by: Pranav Goswami <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shashankss1205 Shashankss1205

Labels
C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
2 participants
@Pranavchiku @Shashankss1205