Skip to content

Add C implementation for @stdlib/math/base/assert/is-even #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Mar 3, 2024

Resolves #1666.

Description

What is the purpose of this pull request?

This pull request adds native C implementation for
@stdlib/math/base/assert/is-even.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aman-095 for this! This is ready to merge.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 3, 2024
@Planeshifter
Copy link
Member

Planeshifter commented Mar 3, 2024

@aman-095 Thanks much for contributing so many C implementations already, it's much appreciated! 🙌

Two small nits for future reference:

  1. It's not necessary to update the copyright year in an existing file like the README.md when adding new content to it; we don't update them usually to keep track on when the files were originally added.
  2. Would you mind creating PRs such as this with a title such as this:

feat: add C implementation for math/base/assert/is-even

Then the suggested commit message when squashing and merging will be auto-populated with the desired format per our git commit message style guide already, making it easier to merge them.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/assert/is-even
3 participants