Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/acovercos #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Pranavchiku opened this issue Dec 24, 2022 · 6 comments · Fixed by #1446
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/acovercos #775

Pranavchiku opened this issue Dec 24, 2022 · 6 comments · Fixed by #1446
Assignees
@Pratik772846
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Pranavchiku commented Dec 24, 2022 •
edited
Loading

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/acovercos.

#include "stdlib/math/base/special/asin.h"

double stdlib_base_acovercos( const double x ) {
    return stdlib_base_asin( 1.0 + x );
}

Package: @stdlib/math/base/special/acovercos

Related Issues

None.

Questions

No.

Other

Reference packages:

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. RFC Request for comments. Feature requests and proposed changes. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Dec 24, 2022
@Pranavchiku Pranavchiku self-assigned this Dec 24, 2022
@Pranavchiku Pranavchiku mentioned this issue Dec 24, 2022
Open
@Pranavchiku Pranavchiku removed their assignment Dec 27, 2022
@Pranavchiku Pranavchiku added the Good First Issue A good first issue for new contributors! label Dec 27, 2022
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. and removed Enhancement Issue or pull request for enhancing existing functionality. labels Feb 23, 2024
@Pratik772846
Copy link
Contributor

@kgryte @Pranavchiku I would like to work on this issue.

@Pranavchiku
Copy link
Member Author

Pranavchiku commented Feb 28, 2024 •
edited
Loading

Thanks @Pratik772846 for your interest, but I'll wait till your PR #1405 gets merged.

@Pratik772846
Copy link
Contributor

@Pranavchiku Can you please assign this issue to me now.

@Pranavchiku
Copy link
Member Author

Awesome, go ahead :)

@adarshpalaskar1
Copy link
Contributor

Hello, can I work on this issue?

@Pranavchiku
Copy link
Member Author

Pranavchiku commented Mar 1, 2024 •
edited
Loading

I will keep door open for both, yes @adarshpalaskar1 you may proceed on it. Thanks for your interest!

@adarshpalaskar1 adarshpalaskar1 mentioned this issue Mar 2, 2024
Merged
1 task
Planeshifter pushed a commit that referenced this issue Mar 2, 2024
@adarshpalaskar1 @Pranavchiku
feat: add C implementation for math/base/special/acovercos
234c6c3 
PR-URL: #1446
Closes: #775

---------

Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this issue Mar 7, 2024
@adarshpalaskar1 @Pranavchiku
feat: add C implementation for math/base/special/acovercos
83c859c 
PR-URL: stdlib-js#1446
Closes: stdlib-js#775

---------

Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pratik772846 Pratik772846

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add C implementation for @stdlib/math/base/special/acovercos adarshpalaskar1/stdlib
4 participants
@kgryte @adarshpalaskar1 @Pranavchiku @Pratik772846