Skip to content

Add C implementation for @stdlib/math/base/special/acovercos #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2024
Merged

Add C implementation for @stdlib/math/base/special/acovercos #1446

merged 4 commits into from
Mar 2, 2024

Conversation

adarshpalaskar1
Copy link
Contributor

Resolves #775.

Description

This PR adds C implementation for @stdlib/math/base/special/acovercos.

Related Issues

Does this pull request have any related issues?
None

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Mar 2, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Mar 2, 2024
kgryte
kgryte requested changes Mar 2, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adarshpalaskar1 Thanks for working on this. The main outstanding thing which needs to be finished based on my initial review are the examples in the /lib/native.js file.

@Pranavchiku Given that you worked previously on similar packages, does this PR satisfy the necessary changes?

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 2, 2024
@Pranavchiku
Copy link
Member

I'll check those once he applies code review and revert back.

Pranavchiku
Pranavchiku approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @adarshpalaskar1 !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 2, 2024
@Planeshifter Planeshifter merged commit 234c6c3 into stdlib-js:develop Mar 2, 2024
bad-in-coding pushed a commit to bad-in-coding/stdlib that referenced this pull request Mar 7, 2024
@adarshpalaskar1 @Pranavchiku
feat: add C implementation for math/base/special/acovercos
83c859c 
PR-URL: stdlib-js#1446
Closes: stdlib-js#775

---------

Signed-off-by: Pranav <[email protected]>
Co-authored-by: Pranav <[email protected]>
Reviewed-by: Pranav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte requested changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/acovercos
5 participants
@adarshpalaskar1 @Pranavchiku @kgryte @stdlib-bot @Planeshifter