Skip to content

feat: add C implementation for math/base/special/maxabs #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

Shashankss1205
Copy link
Contributor

@Shashankss1205 Shashankss1205 commented Mar 3, 2024

Resolves #1460 .

Description

Add C implementation for @stdlib/math/base/special/maxabs

What is the purpose of this pull request?
Feature
This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves 1460#
  • fixes 1460#

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Planeshifter
Copy link
Member

@Shashankss1205 The PR currently also contains your C implementation for math/base/special/max. Each PR should only contain its atomic changes and not unrelated commits. Please rebase your PR branch to only contain the math/base/special/maxabs C implementation. Thanks!

@Shashankss1205
Copy link
Contributor Author

@Shashankss1205 The PR currently also contains your C implementation for math/base/special/max. Each PR should only contain its atomic changes and not unrelated commits. Please rebase your PR branch to only contain the math/base/special/maxabs C implementation. Thanks!

Sorry for the problem caused by my limited knowledge in Git, I made another PR regarding this issue, You can review that and remove this PR from the Repo.

@Planeshifter Planeshifter changed the title feat: Add C implementation for @stdlib/math/base/special/maxabs feat: Add C implementation for math/base/special/maxabs Mar 3, 2024
@Planeshifter Planeshifter changed the title feat: Add C implementation for math/base/special/maxabs feat: add C implementation for math/base/special/maxabs Mar 3, 2024
@kgryte
Copy link
Member

kgryte commented Mar 4, 2024

As this PR is a duplicate of #1671, I am going to close.

@kgryte kgryte closed this Mar 4, 2024
@kgryte kgryte added the Duplicate This issue or pull request already exists. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/maxabs
3 participants