bench: refactor random number generation in stats/base/dists/laplace

[gkbishnoi07]

Resolves #4976

Description

What is the purpose of this pull request?

This pull request:

• Refactors random number generation in JS benchmarks for stats/base/dists/laplace.
• Replaces randu() with uniform() for cleaner and more consistent code.
• Moves the random number generation outside the benchmarking loops to improve efficiency.

Related Issues

Does this pull request have any related issues?

This pull request:

• Resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/laplace #4976

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/laplace/cdf	$\color{green}222/222$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}222/222$ $\color{green}+100.00\%$
stats/base/dists/laplace/ctor	$\color{green}488/488$ $\color{green}+100.00\%$	$\color{green}36/36$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}488/488$ $\color{green}+100.00\%$
stats/base/dists/laplace/entropy	$\color{green}177/177$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}177/177$ $\color{green}+100.00\%$
stats/base/dists/laplace/kurtosis	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/laplace/logcdf	$\color{green}222/222$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}222/222$ $\color{green}+100.00\%$
stats/base/dists/laplace/logpdf	$\color{green}219/219$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}219/219$ $\color{green}+100.00\%$
stats/base/dists/laplace/mean	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/laplace/median	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/laplace/mgf	$\color{green}236/236$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}236/236$ $\color{green}+100.00\%$
stats/base/dists/laplace/mode	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/laplace/pdf	$\color{green}218/218$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}218/218$ $\color{green}+100.00\%$
stats/base/dists/laplace/quantile	$\color{green}222/222$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}222/222$ $\color{green}+100.00\%$
stats/base/dists/laplace/skewness	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/laplace/stdev	$\color{green}176/176$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}176/176$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[gkbishnoi07]

@anandkaranubc @kgryte please review this PRs

[gkbishnoi07]

@anandkaranubc @Planeshifter ready for review

[gkbishnoi07]

@anandkaranubc please review this PRs

[anandkaranubc]

@anandkaranubc please review this PRs

On it!

[gkbishnoi07]

@anandkaranubc please review this PRs

On it!

thanks

[anandkaranubc]

@gkbishnoi07, Can you also make the same changes that were made in #5296?

Specifically, the set::* benchmarks in ctor need their isnan checks updated.

The title should be updated to (for consistency):

bench: refactor random number generation in stats/base/dists/laplace

[gkbishnoi07]

Can you also make the same changes that were made in #5296?

Specifically, the set::* benchmarks in ctor need their isnan checks updated.

Sure, I'll update you soon.

[gkbishnoi07]

@anandkaranubc please review this PRs

[anandkaranubc]

Should I create an issue for changes in ctor?

@gkbishnoi07 Can you point out the files that need this change? Note that this change is only needed where the random number generation occurs outside the benchmarking loops.

Why? Because in cases like these, specifically in the ctor set::* benchmarks, y is being initialized as an array instead of a value. That is why the isnan(y) check appears to be a bug here.

[gkbishnoi07]

Should I create an issue for changes in ctor?

@gkbishnoi07 Can you point out the files that need this change? Note that this change is only needed where the random number generation occurs outside the benchmarking loops.

Why? Because in cases like these, specifically in the ctor set::* benchmarks, y is being initialized as an array instead of a value. That is why the isnan(y) check appears to be a bug here.

@anandkaranubc Got it! I just noticed that some files still have random generation inside the benchmarking loop instead of using a uniform distribution.

First, I'm working on updating those files, and along the way, I'll implement insan(dist.*).

[anandkaranubc]

I just noticed that some files still have random generation inside the benchmarking loop instead of using a uniform distribution.

Yes, and this change is being tracked in #4993. Ideally, this change should already be reflected in the respective PRs. If you have other PRs related to this tracking issue, please update them as well. Thanks!

[gkbishnoi07]

I just noticed that some files still have random generation inside the benchmarking loop instead of using a uniform distribution.

Yes, and this change is being tracked in #4993. Ideally, this change should already be reflected in the respective PRs. If you have other PRs related to this tracking issue, please update them as well. Thanks!

Ok sure!

[gkbishnoi07]

@anandkaranubc, are you reviewing this PR now?

[gkbishnoi07]

@anandkaranubc i applied all changes please look out this PR

[gkbishnoi07]

@anandkaranubc please review this PRs

[anandkaranubc]

@anandkaranubc please review this PRs

On it!

[anandkaranubc]

@gkbishnoi07 The PR still needs some changes.

[gkbishnoi07]

@anandkaranubc changes applied please review this PRs

[anandkaranubc]

It's also good practice to keep your commit messages consistent with code conventions.

Here is the guide

[anandkaranubc]

Please also confirm if the same change is consistent throughout the PR.

[gkbishnoi07]

@anandkaranubc please review

[anandkaranubc]

Everything looks good now! Thanks for working on this.

[gkbishnoi07]

@anandkaranubc stdlib bot again give Needs Review label?

[anandkaranubc]

@anandkaranubc stdlib bot again give Needs Review label?

Yes, the PR needs to go through the maintainers before it can be merged.
Be patient, and it will land soon.

[gkbishnoi07]

@anandkaranubc stdlib bot again give Needs Review label?

Yes, the PR needs to go through the maintainers before it can be merged. Be patient, and it will land soon.

Okay,thanks

[Planeshifter]

Thanks @gkbishnoi07 for your PR and @anandkaranubc for review. Let's get this one in. 🚀

[stdlib-bot]

PR Commit Message

bench: refactor random number generation in `stats/base/dists/laplace`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5270
Closes: https://github.com/stdlib-js/stdlib/issues/4976

Co-authored-by: Gopi Kishan <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: anandkaranubc <[email protected]>

Please review the above commit message and make any necessary adjustments.