bench: fix isnan checks in stats/base/dists

[anandkaranubc]

Resolves none.

Thanks @G4URAV001 for pointing this bug.

Description

What is the purpose of this pull request?

This pull request:

• Replaces isnan( y ) with isnan( dist.a ), isnan( dist.b ), etc., using the appropriate parameters.
• Ensures consistency and correctness in isnan checks throughout the package.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/arcsine/ctor	$\color{green}468/468$ $\color{green}+100.00\%$	$\color{green}43/43$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}468/468$ $\color{green}+100.00\%$
stats/base/dists/bernoulli/ctor	$\color{green}409/409$ $\color{green}+100.00\%$	$\color{green}26/26$ $\color{green}+100.00\%$	$\color{green}15/15$ $\color{green}+100.00\%$	$\color{green}409/409$ $\color{green}+100.00\%$
stats/base/dists/beta/ctor	$\color{green}487/487$ $\color{green}+100.00\%$	$\color{green}34/34$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}487/487$ $\color{green}+100.00\%$
stats/base/dists/betaprime/ctor	$\color{green}419/419$ $\color{green}+100.00\%$	$\color{green}31/31$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}419/419$ $\color{green}+100.00\%$
stats/base/dists/binomial/ctor	$\color{green}439/439$ $\color{green}+100.00\%$	$\color{green}32/32$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}439/439$ $\color{green}+100.00\%$
stats/base/dists/cauchy/ctor	$\color{green}363/363$ $\color{green}+100.00\%$	$\color{green}30/30$ $\color{green}+100.00\%$	$\color{green}13/13$ $\color{green}+100.00\%$	$\color{green}363/363$ $\color{green}+100.00\%$
stats/base/dists/chi/ctor	$\color{green}387/387$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}14/14$ $\color{green}+100.00\%$	$\color{green}387/387$ $\color{green}+100.00\%$
stats/base/dists/chisquare/ctor	$\color{green}406/406$ $\color{green}+100.00\%$	$\color{green}26/26$ $\color{green}+100.00\%$	$\color{green}15/15$ $\color{green}+100.00\%$	$\color{green}406/406$ $\color{green}+100.00\%$
stats/base/dists/cosine/ctor	$\color{green}469/469$ $\color{green}+100.00\%$	$\color{green}35/35$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}469/469$ $\color{green}+100.00\%$
stats/base/dists/degenerate/ctor	$\color{green}495/495$ $\color{green}+100.00\%$	$\color{green}30/30$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}495/495$ $\color{green}+100.00\%$
stats/base/dists/discrete-uniform/ctor	$\color{green}478/478$ $\color{green}+100.00\%$	$\color{green}39/39$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}478/478$ $\color{green}+100.00\%$
stats/base/dists/erlang/ctor	$\color{green}439/439$ $\color{green}+100.00\%$	$\color{green}32/32$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}439/439$ $\color{green}+100.00\%$
stats/base/dists/exponential/ctor	$\color{green}466/466$ $\color{green}+100.00\%$	$\color{green}28/28$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}466/466$ $\color{green}+100.00\%$
stats/base/dists/f/ctor	$\color{green}378/378$ $\color{green}+100.00\%$	$\color{green}30/30$ $\color{green}+100.00\%$	$\color{green}15/15$ $\color{green}+100.00\%$	$\color{green}378/378$ $\color{green}+100.00\%$
stats/base/dists/frechet/ctor	$\color{red}478/479$ $\color{green}+99.79\%$	$\color{red}39/40$ $\color{green}+97.50\%$	$\color{green}20/20$ $\color{green}+100.00\%$	$\color{red}478/479$ $\color{green}+99.79\%$
stats/base/dists/gamma/ctor	$\color{green}468/468$ $\color{green}+100.00\%$	$\color{green}33/33$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}468/468$ $\color{green}+100.00\%$
stats/base/dists/geometric/ctor	$\color{green}469/469$ $\color{green}+100.00\%$	$\color{green}28/28$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}469/469$ $\color{green}+100.00\%$
stats/base/dists/gumbel/ctor	$\color{red}486/488$ $\color{green}+99.59\%$	$\color{red}33/34$ $\color{green}+97.06\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{red}486/488$ $\color{green}+99.59\%$
stats/base/dists/hypergeometric/ctor	$\color{green}415/415$ $\color{green}+100.00\%$	$\color{green}41/41$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}415/415$ $\color{green}+100.00\%$
stats/base/dists/invgamma/ctor	$\color{green}408/408$ $\color{green}+100.00\%$	$\color{green}31/31$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}408/408$ $\color{green}+100.00\%$
stats/base/dists/logistic/ctor	$\color{green}488/488$ $\color{green}+100.00\%$	$\color{green}36/36$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}488/488$ $\color{green}+100.00\%$
stats/base/dists/lognormal/ctor	$\color{green}458/458$ $\color{green}+100.00\%$	$\color{green}35/35$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}458/458$ $\color{green}+100.00\%$
stats/base/dists/negative-binomial/ctor	$\color{green}420/420$ $\color{green}+100.00\%$	$\color{green}31/31$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}420/420$ $\color{green}+100.00\%$
stats/base/dists/pareto-type1/ctor	$\color{green}438/438$ $\color{green}+100.00\%$	$\color{green}32/32$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}438/438$ $\color{green}+100.00\%$
stats/base/dists/poisson/ctor	$\color{green}442/442$ $\color{green}+100.00\%$	$\color{green}27/27$ $\color{green}+100.00\%$	$\color{green}16/16$ $\color{green}+100.00\%$	$\color{green}442/442$ $\color{green}+100.00\%$
stats/base/dists/uniform/ctor	$\color{green}479/479$ $\color{green}+100.00\%$	$\color{green}43/43$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}479/479$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[anandkaranubc]

@kgryte, here is an initial refactoring for stats/base/dists/arcsine. I expected it to be more involved, but it seems that changes are only needed in the ctor files, specifically in the ::set:* benchmarks. I hope I’m not missing anything. If everything looks good, I will update the current PR to include changes for the entire package.

[kgryte]

@anandkaranubc Looks good to me, thus far.

[anandkaranubc]

@anandkaranubc Looks good to me, thus far.

Thanks! It has been updated throughout the package now.

[kgryte]

LGTM. Thanks for following up on this, @anandkaranubc!