Skip to content

Clear console on hot reload #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Clear console on hot reload #544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
387e97f
Clear console on hot reload
ethanh1223 Jul 17, 2017
d21748b
Clear console on hot reload
ethanh1223 Jul 17, 2017
cf4157c
Clear console on hot reload
ethanh1223 Jul 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/rsg-components/Preview/Preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ export default class Preview extends Component {
};

componentDidMount() {
if (console.clear) { // eslint-disable-line no-console
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this condition?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is because the tests fail with a console.clear is not a function if it isn't included.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it should be polyfilled in test/jestsetup.js, not hacked around in the main code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also mock/spy on that function within the test itself, if you wanted:

global.console.clear = jest.fn();

Then you can assert that console.clear was called 😁

console.clear(); // eslint-disable-line no-console
}
this.executeCode();
}

Expand Down