Clear console on hot reload #544
Conversation
| @@ -49,6 +49,9 @@ export default class Preview extends Component { | |||
| }; | |||
|
|
|||
| componentDidMount() { | |||
| if (console.clear) { // eslint-disable-line no-console | |||
There was a problem hiding this comment.
I believe it is because the tests fail with a console.clear is not a function if it isn't included.
There was a problem hiding this comment.
Then it should be polyfilled in test/jestsetup.js, not hacked around in the main code.
There was a problem hiding this comment.
You can also mock/spy on that function within the test itself, if you wanted:
global.console.clear = jest.fn();Then you can assert that console.clear was called 😁
|
Hey @ethanh1223 it looks like this PR kind of got forgotten, do you think it would be possible for you to finish this one? It would definitely be awesome if you could. If not I'm sure @sapegin can take over to get this work merged! |
|
@ndelangen What’s your interest here? ;-) @ethanh1223 Let me know if you need any help. I would try what @tizmagik is suggesting. If you don’t have time to finish the PR soon — let us know, we’ll find someone else. |
|
Finished in #638. |
Adds #519
Clearing console in
ComponentDidMountof Preview makes a lot more sense than Playground -- now understand how the two are related :)Didn't think a doc update was necessary here.