clear console on reload #638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
==========================================
+ Coverage 96.03% 96.04% +<.01%
==========================================
Files 101 101
Lines 1338 1339 +1
Branches 271 271
==========================================
+ Hits 1285 1286 +1
Misses 51 51
Partials 2 2
Continue to review full report at Codecov.
|
|
Thanks, merged! |
* master: Refactor: Replace Markdown links with the Link component instead of the styles (#650) Docs: Clarify logging in Node API (#637) Docs: Correct the `static` modifier note (#643) Docs: Explain behavior for code blocks w/o language tag (#642) Docs: Fix invalid prop type warning (#639) Fix: Clear console on example reload (#638) Docs: Add credits for logo designers (#636) Fix: Update react-docgen (#635) Fix: Correctly print non-Styleguidist exception messages Fix: Fix validation error for uglifyjs-webpack-plugin Docs: Remove react-modal dependency, tweak examples Docs: Update react-styleguidist in CRA example (#632) # Conflicts: # examples/basic/package-lock.json # examples/basic/package.json # examples/cra/package-lock.json # examples/customised/package-lock.json # examples/customised/package.json # examples/express/package-lock.json # examples/express/package.json # examples/sections/package-lock.json # examples/sections/package.json # examples/webpack/package-lock.json # examples/webpack/package.json # package-lock.json # package.json
|
What was the logic behind clearing the console? I recently updated my styleguidist version and I've noticed all of my React warnings are now hidden because the console gets cleared here. |
|
@BruceHubbard I guess it shouldn’t be cleared on hard page reload, only on HMR updates. If it’s not the case, then it’s a bug. |
|
@sapegin I'll open a new issue and see if others are having the same problem. On a hard page reload in Chrome I end up with zero React warnings when I know I should have some. |
fix #519