-
-
Notifications
You must be signed in to change notification settings - Fork 56
feat: add .contains and .contained_by operators to match JS client #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .contains and .contained_by operators to match JS client #100
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 90.10% 90.37% +0.26%
==========================================
Files 22 22
Lines 869 914 +45
==========================================
+ Hits 783 826 +43
- Misses 86 88 +2
Continue to review full report at Codecov.
|
Hi @parrotmac, can you implement tests for the new filters? If you are busy I will do it soon and then we merge the pull request. Are you okay with that? |
Hey! I'll see about adding tests but if you beat me to it feel free to add commits/merge whenever 🙂 |
Thanks for the PR! It looks good to me -- think we just need tests |
Hey! Just added a few tests. Let me know if we want anything changed! |
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.27%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM @parrotmac thanks for the contribution |
This change fixes #99.
Specifically, this change enables a PostgREST
cs.***
query that searches an Array, such as[{"foo": "bar"}]
. This aim to to keep the same API as.cs
/.cd
, modeled after the JS library's implementations.