Skip to content

feat: add .contains and .contained_by operators to match JS client #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions postgrest_py/base_request_builder.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import json
from re import search
from typing import Any, Dict, Iterable, Optional, Tuple, Type, Union

Expand Down Expand Up @@ -209,6 +210,27 @@ def cd(self, column: str, values: Iterable[Any]):
values = ",".join(values)
return self.filter(column, Filters.CD, f"{{{values}}}")

def contains(self, column: str, value: Union[Iterable[Any], str, Dict[Any, Any]]):
if isinstance(value, str):
# range types can be inclusive '[', ']' or exclusive '(', ')' so just
# keep it simple and accept a string
return self.filter(column, Filters.CS, value)
if not isinstance(value, dict) and isinstance(value, Iterable):
# Expected to be some type of iterable
stringified_values = ",".join(value)
return self.filter(column, Filters.CS, f"{{{stringified_values}}}")

return self.filter(column, Filters.CS, json.dumps(value))

def contained_by(self, column: str, value: Union[Iterable[Any], str, Dict[Any, Any]]):
if isinstance(value, str):
# range
return self.filter(column, Filters.CD, value)
if not isinstance(value, dict) and isinstance(value, Iterable):
stringified_values = ",".join(value)
return self.filter(column, Filters.CD, f"{{{stringified_values}}}")
return self.filter(column, Filters.CD, json.dumps(value))

def ov(self, column: str, values: Iterable[Any]):
values = map(sanitize_param, values)
values = ",".join(values)
Expand Down
34 changes: 34 additions & 0 deletions tests/_async/test_filter_request_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,37 @@ def test_multivalued_param(filter_request_builder):
def test_match(filter_request_builder):
builder = filter_request_builder.match({"id": "1", "done": "false"})
assert str(builder.session.params) == "id=eq.1&done=eq.false"


def test_contains(filter_request_builder):
builder = filter_request_builder.contains("x", "a")

assert str(builder.session.params) == "x=cs.a"


def test_contains_dictionary(filter_request_builder):
builder = filter_request_builder.contains("x", {"a": "b"})

# {"a":"b"}
assert str(builder.session.params) == "x=cs.%7B%22a%22%3A+%22b%22%7D"


def test_contains_any_item(filter_request_builder):
builder = filter_request_builder.contains("x", ["a", "b"])

# {a,b}
assert str(builder.session.params) == "x=cs.%7Ba%2Cb%7D"


def test_contains_in_list(filter_request_builder):
builder = filter_request_builder.contains("x", '[{"a": "b"}]')

# [{"a":+"b"}] (the + represents the space)
assert str(builder.session.params) == "x=cs.%5B%7B%22a%22%3A+%22b%22%7D%5D"


def test_contained_by_mixed_items(filter_request_builder):
builder = filter_request_builder.contained_by("x", ["a", '["b", "c"]'])

# {a,["b",+"c"]}
assert str(builder.session.params) == "x=cd.%7Ba%2C%5B%22b%22%2C+%22c%22%5D%7D"
34 changes: 34 additions & 0 deletions tests/_sync/test_filter_request_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,37 @@ def test_multivalued_param(filter_request_builder):
def test_match(filter_request_builder):
builder = filter_request_builder.match({"id": "1", "done": "false"})
assert str(builder.session.params) == "id=eq.1&done=eq.false"


def test_contains(filter_request_builder):
builder = filter_request_builder.contains("x", "a")

assert str(builder.session.params) == "x=cs.a"


def test_contains_dictionary(filter_request_builder):
builder = filter_request_builder.contains("x", {"a": "b"})

# {"a":"b"}
assert str(builder.session.params) == "x=cs.%7B%22a%22%3A+%22b%22%7D"


def test_contains_any_item(filter_request_builder):
builder = filter_request_builder.contains("x", ["a", "b"])

# {a,b}
assert str(builder.session.params) == "x=cs.%7Ba%2Cb%7D"


def test_contains_in_list(filter_request_builder):
builder = filter_request_builder.contains("x", '[{"a": "b"}]')

# [{"a":+"b"}] (the + represents the space)
assert str(builder.session.params) == "x=cs.%5B%7B%22a%22%3A+%22b%22%7D%5D"


def test_contained_by_mixed_items(filter_request_builder):
builder = filter_request_builder.contained_by("x", ["a", '["b", "c"]'])

# {a,["b",+"c"]}
assert str(builder.session.params) == "x=cd.%7Ba%2C%5B%22b%22%2C+%22c%22%5D%7D"