Skip to content

Invalid TS diagnostic mapping with context="module" #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GrzegorzKazana opened this issue Oct 1, 2020 · 0 comments
Closed

Invalid TS diagnostic mapping with context="module" #584

GrzegorzKazana opened this issue Oct 1, 2020 · 0 comments
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@GrzegorzKazana
Copy link
Contributor

Hi all 👋

Describe the bug
When using typescript in components with context="module" diagnostics are hinted on wrong line/character.

To Reproduce
Create a component using TS and module="context" that contains type error. For example

<script context="module" lang="typescript">
    const asd: string = true;
</script>

Expected behavior
Typescript errors should be placed under correct lines/characters for context="module" components.

Screenshots
Actual behavior:
image

System (please complete the following information):

Additional context
Working on a solution, might open a PR soon.

@GrzegorzKazana GrzegorzKazana added the bug Something isn't working label Oct 1, 2020
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants