Skip to content

fix: TS diagnostic mapping for context="module" #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix: TS diagnostic mapping for context="module" #585

merged 1 commit into from
Oct 2, 2020

Conversation

GrzegorzKazana
Copy link
Contributor

Addresses #584

Fixes typescript diagnostic info range for components with context="module".

Before:
image

After:
image

Changes:
Take moduleScriptInfo into account when creating SvelteDocumentSnapshot mapper.

dummdidumm
dummdidumm approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@dummdidumm dummdidumm merged commit 35c2a9f into sveltejs:master Oct 2, 2020
@GrzegorzKazana GrzegorzKazana deleted the fix-diagnostics-mapping-for-modules branch October 2, 2020 06:25
@GrzegorzKazana GrzegorzKazana mentioned this pull request Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrzegorzKazana @dummdidumm