Skip to content

HTTPClient is still using NIOAtomic #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adam-fowler opened this issue Aug 3, 2022 · 3 comments · Fixed by #607
Closed

HTTPClient is still using NIOAtomic #606

adam-fowler opened this issue Aug 3, 2022 · 3 comments · Fixed by #607

Comments

@adam-fowler
Copy link
Member

Given the other NIOAtomics were replaced with ManagedAtomic I assume the HTTPClient one will want to be replaced as well

async-http-client/Sources/AsyncHTTPClient/HTTPClient.swift

Line 39 in 2adca4b

let globalRequestID = NIOAtomic<Int>.makeAtomic(value: 0)

@Lukasa
Copy link
Collaborator

Lukasa commented Aug 3, 2022

Agreed.

@Lukasa
Copy link
Collaborator

Lukasa commented Aug 3, 2022

Looks like this was just an oversight in #603, I'll quickly clean it up.

Lukasa added a commit to Lukasa/async-http-client that referenced this issue Aug 3, 2022
@Lukasa
Remove the last remaining NIOAtomic
1ea91fa 
Motivation

Warnings aren't great, and NIOAtomic is deprecated.

Modifications

Replace the last use of NIOAtomic with ManagedAtomic.

Result

Fewer warnings
Fixes swift-server#606
@Lukasa Lukasa mentioned this issue Aug 3, 2022
Merged
@Lukasa Lukasa closed this as completed in 0527bbb Aug 3, 2022
@Lukasa
Copy link
Collaborator

Lukasa commented Aug 3, 2022

Shipped in 1.11.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the last remaining NIOAtomic Lukasa/async-http-client
2 participants
@Lukasa @adam-fowler