Skip to content

Use swift-atomics instead of NIOAtomics #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

Use swift-atomics instead of NIOAtomics #603

merged 2 commits into from
Jul 13, 2022

Conversation

dnadoba
Copy link
Collaborator

@dnadoba dnadoba commented Jul 11, 2022

NIOAtomics was deprecated in apple/swift-nio#2204 in favor of swift-atomics https://github.com/apple/swift-atomics

fabianfett
fabianfett approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnadoba
Copy link
Collaborator Author

dnadoba commented Jul 13, 2022

Nightly fails because of Sendable warnings

@dnadoba dnadoba merged commit 2adca4b into swift-server:main Jul 13, 2022
@dnadoba dnadoba deleted the dn-atomics branch July 13, 2022 12:48
@dnadoba dnadoba added 🆕 semver/minor Adds new public API. 🔨 semver/patch No public API change. and removed 🆕 semver/minor Adds new public API. labels Aug 2, 2022
@Lukasa Lukasa mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnadoba @fabianfett