Skip to content

use Swift 5.1.3 in CI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2019
Merged

use Swift 5.1.3 in CI #145

merged 1 commit into from
Dec 18, 2019

Conversation

weissi
Copy link
Contributor

@weissi weissi commented Dec 17, 2019

No description provided.

@weissi weissi requested a review from tomerd December 17, 2019 21:47
@tomerd tomerd merged commit 669745f into master Dec 18, 2019
@@ -7,7 +7,7 @@ services:
build:
args:
ubuntu_version: "bionic"
swift_version: "5.1"
swift_version: "5.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means we would need to keep this up to date as minor revisions are released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomerd Yes. Is there another way to force the CI to pull the latest 5.1?

Copy link
Contributor

@tomerd tomerd Dec 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue here is that docker will catch the 5.1 image (the tag. latest is a special case), so the only way would be to forcibly invalidate the cache which is not ideal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I think manually bumping is fine for now. Or we implement something where it’d kill the cache once a week or so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can do that. we can also create a CI job that will nuke the relevant cache for a specific version. this may be part of the checklist when we release new versions?

@tomerd tomerd added the 🔨 semver/patch No public API change. label Dec 18, 2019
@weissi weissi deleted the jw-513 branch May 13, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants