Skip to content

use Swift 5.1.3 in CI #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2019
Merged

use Swift 5.1.3 in CI #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/docker-compose.1804.51.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
build:
args:
ubuntu_version: "bionic"
swift_version: "5.1"
swift_version: "5.1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means we would need to keep this up to date as minor revisions are released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomerd Yes. Is there another way to force the CI to pull the latest 5.1?

Copy link
Contributor

@tomerd tomerd Dec 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue here is that docker will catch the 5.1 image (the tag. latest is a special case), so the only way would be to forcibly invalidate the cache which is not ideal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I think manually bumping is fine for now. Or we implement something where it’d kill the cache once a week or so?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can do that. we can also create a CI job that will nuke the relevant cache for a specific version. this may be part of the checklist when we release new versions?


test:
image: async-http-client:18.04-5.1
Expand Down