[HTTPClient.Configuration] Make connection pool size configurable #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-make-http1-pool-size-configurable
branch
2 times, most recently
from
e318759 to
41b5b16
Compare
Lukasa
reviewed
Sep 24, 2021
| } | ||
| } | ||
| } | ||
| let timeout = DispatchTime.now() + .seconds(180) |
There was a problem hiding this comment.
This timeout is really long for CI. Can we lower it?
There was a problem hiding this comment.
I'm afraid we will need to change the number of requests and threads to something smaller, if we change the timeout to 60 seconds :)
Test Case 'HTTPClientTests.testConnectionPoolSizeConfigValueIsRespected' started at 2021-09-24 13:48:02.845
/code/Tests/AsyncHTTPClientTests/HTTPClientTests.swift:3101: error: HTTPClientTests.testConnectionPoolSizeConfigValueIsRespected : failed - Timed out
/code/Tests/AsyncHTTPClientTests/HTTPClientTests.swift:3089: error: HTTPClientTests.testConnectionPoolSizeConfigValueIsRespected : XCTAssertNoThrow failed: threw error "HTTPClientError.cancelled" -
/code/Tests/AsyncHTTPClientTests/HTTPClientTests.swift:3089: error: HTTPClientTests.testConnectionPoolSizeConfigValueIsRespected : XCTAssertNoThrow failed: threw error "HTTPClientError.alreadyShutdown" -
There was a problem hiding this comment.
Reduced the amount of requests.
| self.init(idleTimeout: idleTimeout, concurrentHTTP1ConnectionsPerHostSoftLimit: 8) | ||
| } | ||
|
|
||
| public init(idleTimeout: TimeAmount = .seconds(60), concurrentHTTP1ConnectionsPerHostSoftLimit: Int = 8) { |
There was a problem hiding this comment.
We should avoid a new defaulted parameter here.
There was a problem hiding this comment.
I think we can just remove the default value and get the "behaviour" of a default value because we have the init above which only takes idleTimeout as a parameter.
fabianfett
force-pushed
the
ff-make-http1-pool-size-configurable
branch
2 times, most recently
from
fa60917 to
149fdca
Compare
|
Failing |
fabianfett
force-pushed
the
ff-make-http1-pool-size-configurable
branch
from
149fdca to
0334abf
Compare
fabianfett
force-pushed
the
ff-make-http1-pool-size-configurable
branch
from
0334abf to
58013d9
Compare
fabianfett
added
🆕 semver/minor
Lukasa
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #373