-
Notifications
You must be signed in to change notification settings - Fork 76
Several changes in build-script-helper.py to support building indexstore-db in a unified build #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b048385
to
f1bdb6d
Compare
f1bdb6d
to
3080cc9
Compare
Since we don't "install" this product anywhere currently, how about we just use the test target instead? Then we can keep the main products 'auto'.
|
AFAICT cleaning the build directory prior to building was done to work around a bug in SwiftPM at some point. I don’t think that it’s needed anymore.
When we build SourceKit-LSP in a unified SwiftPM workspace, a simple `swift build` invocation will build all products in the unified workspace (not just SourceKit-LSP products).
So far, this has not been relevant because indexstore-db didn’t have any dependencies. Once we build indexstore-db in a unified SwiftPM the `swift build` invocation will also resolve Package.swift for the other packages in the unified build, which need this environment variable.
`--build-path` has been deprectated in favor of `--scratch-path` in SwiftPM.
3080cc9
to
34e4b09
Compare
benlangmuir
approved these changes
Aug 3, 2022
bnbarham
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the analogous changes from swiftlang/sourcekit-lsp#597 as well as the following additional ones:
swift build
invocation will also resolve Package.swift for the other packages in the unified build, which need this environment variable.