Several changes in build-script-helper.py to support building SourceKit-LSP in a unified build #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/unified-build
branch
6 times, most recently
from
1ba8239 to
e785c1e
Compare
AFAICT cleaning the build directory prior to building was done to work around a bug in SwiftPM at some point. I don’t think that it’s needed anymore.
ahoppen
force-pushed
the
pr/unified-build
branch
from
e785c1e to
6bad404
Compare
ahoppen
changed the title
|
@swift-ci Please test |
benlangmuir
reviewed
Aug 3, 2022
benlangmuir
approved these changes
Aug 3, 2022
When we build SourceKit-LSP in a unified SwiftPM workspace, a simple `swift build` invocation will build all products in the unified workspace (not just SourceKit-LSP products).
Since swiftlang/swift-package-manager#4208 SwiftPM no longer adds rpath to the toolchain libraries, so we don’t need to exclude them.
`--build-path` has been deprectated in favor of `--scratch-path` in SwiftPM.
ahoppen
force-pushed
the
pr/unified-build
branch
from
6bad404 to
ac24fd6
Compare
|
@swift-ci Please test |
finagolfin
added a commit
to finagolfin/sourcekit-lsp
that referenced
this pull request
Feb 20, 2023
Pull swiftlang#597 incorrectly removed this, as it's still needed on ELF platforms.
finagolfin
added a commit
to finagolfin/sourcekit-lsp
that referenced
this pull request
Feb 20, 2023
Pull swiftlang#597 incorrectly removed this, as it's still needed on ELF platforms.
finagolfin
added a commit
to finagolfin/sourcekit-lsp
that referenced
this pull request
Mar 6, 2023
Pull swiftlang#597 incorrectly removed this, as it's still needed on ELF platforms.
finagolfin
added a commit
to finagolfin/sourcekit-lsp
that referenced
this pull request
Mar 10, 2023
…linux Pull swiftlang#597 incorrectly removed this, as it's still needed on ELF platforms.
finagolfin
added a commit
to finagolfin/sourcekit-lsp
that referenced
this pull request
Mar 11, 2023
…linux Pull swiftlang#597 incorrectly removed this, as it's still needed on ELF platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple of small changes that are necessary to build SourceKit-LSP in a unified SwiftPM build, removing the need to build indexstore-db twice (once for indexstore-db testing and once for SourceKit-LSP testing).
swift buildinvocation will build all products in the unified workspace (not just SourceKit-LSP products).--multiroot-data-fileoption to build sourcekit-lsp in a unified build--build-pathbeing deprecated in favor of--scratch-path--build-pathto--scratch-pathin SwiftPM invocation--build-pathhas been deprectated in favor of--scratch-pathin SwiftPM.