[lldb] Improve determinism of TestSwiftActorUnprioritisedJobs #10417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change TestSwiftActorUnprioritisedJobs to prevent non-deterministic failures. 1. Removes the sleep, replacing it with an indefinite read from stdin 2. Makes the test not dependent on Foundation 3. Delays the breakpoint by inserting a stalling Task.sleep The last one needs explanation. The failures happen when the queue (used to serially execute actor work) has not finished preparing by the time the breakpoint is hit. The sleep delays the breakpoint from being hit, and that delay should give the queue the time needed to be in a state needed by this test.
|
@swift-ci test macOS |
|
I'll be running CI a number of times to make sure this test passes. |
|
The failure happened in https://ci.swift.org/job/apple-llvm-project-pr-macos/7069/ back to the drawing board 🫤 |
|
gonna try another run or two, to get a rough rate of pass/fail. |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change TestSwiftActorUnprioritisedJobs to prevent non-deterministic failures.
The last one needs explanation. The failures happen when the queue (used to serially
execute actor work) has not finished preparing by the time the breakpoint is hit. The
sleep delays the breakpoint from being hit, and that delay should give the queue the
time needed to be in a state needed by this test.