Skip to content

[lldb] Improve determinism of TestSwiftActorUnprioritisedJobs #10417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
class TestCase(TestBase):

@swiftTest
@skipUnlessFoundation
def test_actor_unprioritised_jobs(self):
"""Verify that an actor exposes its unprioritised jobs (queue)."""
self.build()
Expand All @@ -20,8 +19,7 @@ def test_actor_unprioritised_jobs(self):
unprioritised_jobs = defaultActor.GetChildMemberWithName("unprioritised_jobs")
# There are 4 child tasks (async let), the first one occupies the actor
# with a sleep, the next 3 go on to the queue.
# TODO: rdar://148377173
# self.assertEqual(unprioritised_jobs.num_children, 3)
self.assertEqual(unprioritised_jobs.num_children, 3)
for job in unprioritised_jobs:
self.assertRegex(job.name, r"^\d+")
self.assertRegex(job.summary, r"^id:\d+ flags:\S+")
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import Foundation

actor Actor {
var data: Int = 15

func occupy() async {
Thread.sleep(forTimeInterval: 100)
// Block on input that will never be received.
_ = readLine()
}

func work() async -> Int {
Expand All @@ -21,6 +20,11 @@ actor Actor {
async let _ = a.work()
async let _ = a.work()
async let _ = a.work()

// Yield to fully prepare the queue used to run the actor. Without this,
// the test can sometimes fail.
try? await Task.sleep(for: .seconds(2))

print("break here")
}
}