Don’t include files from package dependencies in the syntactic test index #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
no-tests-from-package-dependencies
branch
from
abf31a8 to
93cb305
Compare
ahoppen
changed the title
|
swiftlang/swift-package-manager#7492 @swift-ci Please test |
…ndex `SwiftPMBuildSystem.testFiles()` returned all source files in the package, including files of package dependencies. This caused us to index those files for tests in the syntactic test index, which we should not. Make `SwiftPMBuildSystem.testFiles` only return files from the root package. Also add test infrastructure to be able to test cross-package functionality. rdar://126965614
ahoppen
force-pushed
the
no-tests-from-package-dependencies
branch
from
93cb305 to
1d9b67b
Compare
|
swiftlang/swift-package-manager#7492 @swift-ci Please test |
|
swiftlang/swift-package-manager#7492 @swift-ci Please test Windows |
1 similar comment
|
swiftlang/swift-package-manager#7492 @swift-ci Please test Windows |
bnbarham
approved these changes
May 1, 2024
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 1, 2024
…lsp API (#7492) This is used so we don’t search for tests in targets of package dependencies. Companion of swiftlang/sourcekit-lsp#1201 rdar://126965614
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…lsp API (swiftlang#7492) This is used so we don’t search for tests in targets of package dependencies. Companion of swiftlang/sourcekit-lsp#1201 rdar://126965614
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…lsp API (swiftlang#7492) This is used so we don’t search for tests in targets of package dependencies. Companion of swiftlang/sourcekit-lsp#1201 rdar://126965614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPMBuildSystem.testFiles()returned all source files in the package, including files of package dependencies. This caused us to index those files for tests in the syntactic test index, which we should not.Make
SwiftPMBuildSystem.testFilesonly return files from the root package.Also add test infrastructure to be able to test cross-package functionality.
rdar://126965614