Report whether a target is part of the root package in the sourcekit-lsp API #7492
Conversation
…lsp API This is used so we don’t search for tests in targets of package dependencies. rdar://126965614
| @@ -22,31 +22,45 @@ import class Build.BuildPlan | |||
| import class Build.ClangTargetBuildDescription | |||
| import class Build.SwiftTargetBuildDescription | |||
| import struct PackageGraph.ResolvedModule | |||
| import struct PackageGraph.ModulesGraph | |||
There was a problem hiding this comment.
Is there a way to implement this with private import? All of the types above without private import should not leak outside of SourceKitLSPAPI and we should work on making this list smaller instead of adding more to it.
There was a problem hiding this comment.
I viewed it similarly to how we use ResolvedModule in the API as well.
I agree that we should not expose these types in SourceKitLSPAPI, but completely wrapping ModuleGraph will be a fairly significant undertaking (we use it in other places in SourceKit-LSP as well) and I think that should be done when we switch all of SourceKitLSP to only use the API module. Doing that for 6.0 is too much work and risk though, so I'd prefer to keep this as-is for now and schedule time for 6.1 to extend the SourceKitLSPAPI module so that we don't need to import any other modules. WDYT?
There was a problem hiding this comment.
That's fair, although I would like ModulesGraph (and Resolved* types) to go through a significant refactoring for performance improvements in the near future, which very likely is going to be a breaking change. I'm not sure of the timeline yet, it might need to be included in 6.0 if we see performance regressing too much due to other changes.
There was a problem hiding this comment.
That's fair. If an abstraction layer for LSP falls out of that, that's great. Otherwise, I'm happy to assist with any changes that need to be done in SourceKit-LSP due to the refactoring.
|
@swift-ci test |
|
@swift-ci Please test |
|
@swift-ci Please test |
- **Explanation**: Cherry-pick the following to PRs which are companions of swiftlang/sourcekit-lsp#1213 - #7505 - #7492 - **Scope**: CMake build and SourceKit-LSP API - **Risk**: Low, the SourceKit-LSP API is only used by SourceKit-LSP and the CMake build changes will all be caught at build-time - **Testing**: n/a - **Issue**: n/a - **Reviewer**: @DougGregor and @MaxDesiatov on #7505 and #7492 --------- Co-authored-by: Ben Barham <[email protected]>
…lsp API (swiftlang#7492) This is used so we don’t search for tests in targets of package dependencies. Companion of swiftlang/sourcekit-lsp#1201 rdar://126965614
…lsp API (swiftlang#7492) This is used so we don’t search for tests in targets of package dependencies. Companion of swiftlang/sourcekit-lsp#1201 rdar://126965614
This is used so we don’t search for tests in targets of package dependencies.
Companion of swiftlang/sourcekit-lsp#1201
rdar://126965614