-
Notifications
You must be signed in to change notification settings - Fork 59
Add support for @TopicsVisualStyle
#419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @TopicsVisualStyle
#419
Conversation
Render node spec updates for this change are here: https://github.com/apple/swift-docc/pull/368/files#diff-fc7c8431152d3d494899ec4b551f1a5d1249ed44c853e05da1cc26374d9d4c54 |
a88c8ff
to
f3b9e44
Compare
974d5cb
to
af9423e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to fully test this yet, but I gave an initial look at the code (mostly ignoring the changes from the card PR)
I'll probably be able to test this with some real content tomorrow.
All done, give it another look. |
db887fc
to
7c0f4d6
Compare
… child `.title` classes.
7c0f4d6
to
928a1d5
Compare
@swift-ci test |
@swift-ci test |
Bug/issue #, if applicable: 97716047
Summary
This PR add support to both the new docc
@TopicsVisualStyle
directive.Note:
This PR assumes the RenderJSON based on some early discussions. It should be double checked when the DocC PR for this lands.
Dependencies
This PR builds on top of the work from a few other PRs:
#418
#409
#417
Docc PR - swiftlang/swift-docc#368
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test
, and it succeeded