Further enhance the optional DocumentationHero background #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobromir-hristov
force-pushed
the
dhristov/r97716923-optional-doc-hero
branch
2 times, most recently
from
b16c6e1 to
14ab26b
Compare
dobromir-hristov
force-pushed
the
dhristov/r97716923-optional-doc-hero
branch
from
14ab26b to
09302d4
Compare
…e is a grid, or via a prop from DocumentationTopic
dobromir-hristov
force-pushed
the
dhristov/r97716923-optional-doc-hero
branch
from
09302d4 to
c264299
Compare
|
@swift-ci test |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 97716923
Summary
Adds extra checks to the
DocumentationHeroenhanced background logic, to check thetopicSectionsStyleforgrid-like styles. Adds extra prop to enable bypassing the check and disable directly.Dependencies
@TopicsVisualStyle#419Testing
Build an archive via swiftlang/swift-docc#368
Steps:
topicSectionsStylethat aredetailedGridorcompactGriddo not render an enhanced hero bg.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded