Obtain match output elements without materializing the output. #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
rxwei
force-pushed
the
fix-267
branch
2 times, most recently
from
36cbe78 to
59e77ba
Compare
|
@swift-ci please test |
|
@swift-ci please test |
rxwei
commented
Jun 4, 2022
| func sizeAndAlignMask<T>(_: T.Type) -> (Int, Int) { | ||
| (MemoryLayout<T>.size, MemoryLayout<T>.alignment - 1) | ||
| } | ||
| // The ABI of an offset-based key path only stores the byte offset, so |
|
@swift-ci please test |
rxwei
commented
Jun 5, 2022
| output[keyPath: keyPath] | ||
| // Note: We should be able to get the element offset from the key path | ||
| // itself even at compile time. We need a better way of doing this. | ||
| guard let outputTupleOffset = MemoryLayout.tupleElementIndex( |
There was a problem hiding this comment.
When we store the whole match inside the capture list, we will be able to precompute these offsets for all elements in a Regex.Match. I'll do that next.
|
@swift-ci please test |
milseman
reviewed
Jun 7, 2022
| ) | ||
| return typeErasedMatch as! Output | ||
| } | ||
| } | ||
|
|
||
| var wholeMatchType: Any.Type { | ||
| value.map { type(of: $0) } ?? Substring.self |
There was a problem hiding this comment.
What if it's optional? Also, are we tracking nested optionals correctly here (I.e. do they get turned into values or are they counted)?
There was a problem hiding this comment.
When there's no dedicated value for whole match, it can only be a Substring.
|
@swift-ci please test |
natecook1000
pushed a commit
to natecook1000/swift-experimental-string-processing
that referenced
this pull request
Jun 17, 2022
Obtain match output elements without materializing the output.
This was referenced Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #267.