[5.7] Merge basic performance enhancements and unmerged prior dependencies #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obtain match output elements without materializing the output.
Fully generalize "whole match" in the engine and enable transforming custom types
Add additional capture transform tests.
Remove `buildEither`.
top level code is real weird, let's not talk about it
20x perf speedup in the "BasicBacktrack" benchmarks.
* Re-use the same executor, remember semantic mode. Gives around a 20% perf improvement to first-match style benchmarks. * Remove history preservation Cuts down on memory usage and avoids some ARC overhead. ~20% gains on "AllMatches" and related benchmarks. * Lower-level matchSeq Avoid collection algorithms inside matchSeq, which are liable to add ARC and inefficiencies. Results in a 3x improvement to ReluctantQuantWithTerminal.
Gives a 7x improvement to firstMatch-style benchmarks like "FirstMatch", 2-3x to CSS and basic backtracking benchmarks. Thanks to @rctcwyvrn for the original code.
This was referenced Jun 17, 2022
|
If this needs to be coordinated with swiftlang/swift#59555, then it makes sense to merge together. Otherwise we lose most of the value from a batch PR "just for testing". |
natecook1000
changed the title
milseman
changed the title
stephentyrone
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in some basic performance improvements from #497, #495, and #494. Those are built on top of the benchmark suite which we pull in #491. These have some conflicts as they are built on top of a few un-cherry-picked PRs #469, #470, #482, and #471, which we cherry-pick here. They require compiler side changes in swiftlang/swift#59555. We have verified that this batch passes CI and we recommend taking these changes as a batch.