[bootstrap] Add swift-argument-parser as a bootstrapped swift-driver dependency #2739
Conversation
owenv
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
owenv
force-pushed
the
driver-add-argparse
branch
from
9060ebd to
0e86eba
Compare
|
Marking this as a draft until I have a chance to make the update-checkout changes |
Sources/Build/CMakeLists.txt
Outdated
| @@ -20,6 +20,7 @@ target_link_libraries(Build PUBLIC | |||
| SPMBuildCore | |||
| CYaml | |||
| Yams | |||
| ArgumentParser | |||
There was a problem hiding this comment.
This isn't strictly necessary yet, but I think it'll allow incremental adoption of ArgumentParser in the driver library
|
swiftlang/swift-driver#92 @swift-ci please test |
|
There might be some remaining build issues on Linux to resolve here, but let's see how it works with an updated ArgumentParser swiftlang/swift-driver#92 |
|
swiftlang/swift-driver#92 |
2 similar comments
|
swiftlang/swift-driver#92 |
|
swiftlang/swift-driver#92 |
|
FYI, also learned about Docker as another place to update: #2767 |
owenv
force-pushed
the
driver-add-argparse
branch
from
8cb9402 to
3d44a96
Compare
|
@DougGregor this seems to be still draft. let us know when you need a review |
|
We should go ahead and do this when it's ready. Are you stuck on something, @owenv ? |
|
@DougGregor I think we'll want to coordinate this with @natecook1000's changes in #2653 so that CI & update-checkout can be configured to pull a single version of ArgumentParser for use in both swift-driver and SPM. I'll try and test this with swift-argument-parser 0.3 sometime in the next few days |
Yeah, this absolutely makes sense. |
|
#2653 is almost ready to be merged. Independently, those diffs also involved making similar changes to the bootstrap script as the diffs in this PR (I didn't realize at the time that this PR already had those changes). We can make those changes use the same variable names in the bootstrap script as this diff uses, so that when rebased, this will be a fairly clean addition to those diffs (essentially just making the Build module link against Argument parser). Does that make sense as a way to proceed? |
|
@abertelrud That plan sounds good to me! |
owenv
force-pushed
the
driver-add-argparse
branch
from
3d44a96 to
6742650
Compare
|
This is now up-to-date with swiftlang/swift-driver#92, but we'll still wait for #2653 to land before merging |
owenv
force-pushed
the
driver-add-argparse
branch
from
6742650 to
58dcafb
Compare
Don't build ArgumentParser example projects
owenv
force-pushed
the
driver-add-argparse
branch
from
58dcafb to
047b349
Compare
|
swiftlang/swift-driver#92 |
1 similar comment
|
swiftlang/swift-driver#92 |
|
@owenv Please merge when ready (or I can do it, if it can go in at any time — are you coordinating with a PR in swift-driver as well?). |
|
@abertelrud thanks for the reminder! I just realized I forgot to request a review on the corresponding swift-driver PR (swiftlang/swift-driver#92). Once that's approved, I might need help with the cross-repository merge (I don't have write access to this repository) |
|
@owenv No problem, just let me know when this is ready to merge. Thanks! |
|
@abertelrud it looks like everything is approved so this should be ready to merge now. Thanks for your help with this! |
|
Let's do it! |
Only the last commit is new, the rest is from #2736