[SR-14718] Only pass -enable-library-evolution for PackageDescription and PackagePlugin on macOS
#3526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and PackagePlugin on macOS Because PackageDescription unintentionally exports Foundation (for which a fix was attempted but then reverted after it broke some packages), we can only enable library evolution on Darwin platforms. rdar://78827075
|
@swift-ci please smoke test |
neonichu
approved these changes
Jun 3, 2021
tomerd
approved these changes
Jun 3, 2021
benlangmuir
approved these changes
Jun 3, 2021
drodriguez
added a commit
to drodriguez/swift-package-manager
that referenced
this pull request
Feb 15, 2023
Reverts 1998284 / swiftlang#3526 Related to SR-14718 (swiftlang#4416). Since swiftlang#3526 was merged, swiftlang#5874 tried to apply the original idea of using `@_implementationOnly Foundation` in PackageDescription/Plugin to avoid leaking `Foundation` into the manifests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Because PackageDescription unintentionally exports Foundation (for which a fix was attempted but then reverted after it broke some packages — see SR-14718), we can only enable library evolution on Darwin platforms.
Modifications:
-enable-library-evolutionon the macOS platformrdar://78827075