[5.5] Build PackageDescription and PackagePlugin universal on macOS platform #3536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
added
5.5
ready
|
@swift-ci please test |
tomerd
approved these changes
Jun 9, 2021
…lugin libraries universal when cross-compiling. Also unify and clean up some of the logic by making the helper function that installs libSwiftPM be more generic, and also apply to PackageDescription and PackagePlugin. rdar://75186958 (cherry picked from commit 637fa7a)
…d PackagePlugin on macOS Because PackageDescription unintentionally exports Foundation (for which a fix was attempted but then reverted after it broke some packages), we can only enable library evolution on Darwin platforms. rdar://78827075 (cherry picked from commit 6e7bb87)
…brary evolution via unsafe flags There isn't currently a way for package authors to enable library evolution or module interfaces from the package manifest. They can pass `-enable-library-evolution` in their unsafe flags, but because `-emit-module-interface` requires a path parameter, it isn't something that can be set in the manifest. This adds a way to infer XCBuild settings based on values set in manifest-declared settings. The idea is to implement semantics appropriately for each platform based on generalized flags passed from the manifest. rdar://78773077 (cherry picked from commit 4569c7f)
abertelrud
force-pushed
the
eng/build-pkgdescription-and-pkgplugin-universal-5.5
branch
from
6182815 to
0e85e74
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
neonichu
approved these changes
Jun 25, 2021
…ries, since these should not be part of the installed toolchain. (cherry picked from commit 3741792)
|
@swift-ci please test |
|
@swift-ci please test linux |
|
Anything holding this up? My cross-compilation pull #3577 relies on this pull to cross-compile these libraries. |
No, it looks like this has all the necessary approvals. Merging. |
abertelrud
deleted the
eng/build-pkgdescription-and-pkgplugin-universal-5.5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5.5 cherry-pick of a sequence of changes to build PackageDescription and PackagePlugin universal on macOS platform. SwiftPM switches to the XCBuild build system when building universal, and this PR includes the necessary follow-up changes to make that work.
This includes 5.5 cherry-picks of the changes in:
#3431
#3526
#3528
each as a separate commit containing the original commit hash from which it was cherry-picked.
This PR builds on top of the PR #3492, which is kept as a separate PR since it is for a different issue.
The three are put up as one PR since they all are steps toward fixing the same issue.