Remove rpaths to the toolchain libraries #4208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added to enable workflows like `swift run` on systems without Swift libraries in the OS. SwiftPM does not run on any systems old enough anymore at this point, so these rpaths can be removed at this point.
|
@swift-ci please smoke test |
tomerd
approved these changes
Mar 12, 2022
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Mar 15, 2022
Previously, we were relying on SwiftPM adding the toolchain’s stdlib to the rpaths and we were finding `lib_InternalSwiftSyntaxParser.dylib` inside the stdlib directory. This behavior was removed in swiftlang/swift-package-manager#4208. Explicitly add the directory that contains `lib_InternalSwiftSyntaxParser.dylib` as an rpath to SwiftSyntaxParser when compiling SwiftSyntax using build-script.py. The major downsides of this approach are - You can no longer run SwiftSyntaxParser tests for SwiftSyntax in Xcode with an open source toolchain - Maybe this isn’t too bad because it only affects SwiftSyntaxParser tests and those can be run from the command line - All adopters of SwiftSyntax also need to explicitly specify the `lib_InternalSwiftSyntaxParser.dylib` rpath - Maybe this isn’t too bad because on Linux `lib_InternalSwiftSyntaxParser.dylib` is in the standard search paths and on macOS we start shipping `lib_InternalSwiftSyntaxParser.dylib` as a binary dependency.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jul 31, 2022
Since swiftlang/swift-package-manager#4208 SwiftPM no longer adds rpath to the toolchain libraries, so we don’t need to exclude them.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Jul 31, 2022
Since swiftlang/swift-package-manager#4208 SwiftPM no longer adds rpath to the toolchain libraries, so we don’t need to exclude them.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Aug 3, 2022
Since swiftlang/swift-package-manager#4208 SwiftPM no longer adds rpath to the toolchain libraries, so we don’t need to exclude them.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Aug 3, 2022
Since swiftlang/swift-package-manager#4208 SwiftPM no longer adds rpath to the toolchain libraries, so we don’t need to exclude them.
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Aug 3, 2022
Since swiftlang/swift-package-manager#4208 SwiftPM no longer adds rpath to the toolchain libraries, so we don’t need to exclude them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally added to enable workflows like
swift runon systems without Swift libraries in the OS. SwiftPM does not run on any systems old enough anymore at this point, so these rpaths can be removed at this point.