-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Utilities/bootstrap: fix ignored --clang-path
option
#5894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
1 similar comment
@swift-ci please smoke test |
@swift-ci please smoke test Linux |
Do we need to do anything to propagate it to the second stage build as well? |
By that, are you referring to "Building SwiftPM (with a freshly built swift-build)" stage? If so, I haven't found a way to instruct |
Yep, that's what I meant. Looking at |
This fixes an issue resolved in jpsim/Yams#353, which is currently blocking swiftlang/swift-package-manager#5894
This fixes an issue resolved in jpsim/Yams#353, which is currently blocking swiftlang/swift-package-manager#5894.
@swift-ci please smoke test |
Ignoring this option caused issues on certain Linux distributions, where the process of bringing up clang is convoluted and `bootstrap` ended up using GCC, which caused build failures.
f88cd71
to
a9ef6b8
Compare
@swift-ci please smoke test |
Motivation:
Utilities/bootstrap
has--clang-path
, which currently is parsed, but not propagated anywhere. Ignoring this option caused issues on certain Linux distributions, where the process of bringing up clang is convoluted andbootstrap
ended up using GCC, which caused build failures.Modifications:
args.clang_path
value is now passed to CMake as-DCMAKE_C_COMPILER
.Result:
Build failures on Linux in certain configurations are fixed.