Improve error message about the PackageGraphError.productDependencyNotFound

[k-kohey]

Fixed a bug in the productDependencyNotFound error message

Motivation:

fix #7398

The above issue suggests the following two defects.

1. package dependency resolution changes depending on the order of packages (alphabetical order)
2. the phrase "Did you meen..." in the error message in the error message is not on target.

Modifications:

The first problem is as described in the issue, if users rename the directory containing Package.swift from repro to zzz, the "Did you meen..." will appear. Essentially, the error minutes should be displayed in full, regardless of the name of the directory. This is due to the fact that the loop used to resolve dependencies depends on the alphabetical order of the directories and the side effect on allTargetName inside the loop. Therefore, the side effect for allTargetName inside the loop has been moved to the outside of the loop.

The second problem is that when dependency A of a package is not found, a strange suggestion "Did you meen A? ", which is a strange suggestion. This is because when a dependency is not found, the message "Did you meen <target name>" is printed if there is a dependency with a similar name (even the exact same name). Thus, if the names are the same, "Did you meen .product(name: ... , package: "swift-argugument")"" instead of the found target name.

Result:

Command to execute:
swift build

Result of command:.
error: 'repro': product 'ArgumentParser' required by package 'repro' target 'repro' not found. Did you mean '.product(name: "ArgumentParser", package: "swift-argument-parser")'?

Condition:
The following steps were taken to create the environment.

1. mkdir repro
2. cd repro
3. swift package init --type executable
4. Open Package.swift and make sure it has this content:

// swift-tools-version: 5.10

import PackageDescription

let package = Package(
    name: "repro",
    dependencies: [
        .package(url: "https://github.com/apple/swift-argument-parser.git", from: "1.3.0")
    ],
    targets: [
        .executableTarget(
            name: "repro",
            dependencies: ["ArgumentParser"]
        )
    ]
)

[k-kohey]

This PR fix will cause the error message to include "Did you mean...".
Previously, this message was not displayed depending on the name of the package directory.

[k-kohey]

I wrote the following test code to test the output of this message.

func test_() throws {
    let fs = InMemoryFileSystem(emptyFiles:
        "/zzz/Sources/zzz/main.swift",
        "/aaa/Sources/aaa/source.swift"
    )

    let observability = ObservabilitySystem.makeForTesting()
    let g = try loadModulesGraph(
        fileSystem: fs,
        manifests: [
            Manifest.createRootManifest(
                displayName: "zzz",
                path: "/zzz",
                dependencies: [
                    .remoteSourceControl(
                        url: "https://example.com/example.git",
                        requirement: .exact("1.3.0")
                    )
                ],
                products: [],
                targets: [
                    TargetDescription(
                        name: "zzz",
                        dependencies: ["aaa"],
                        type: .executable
                    )
                ]),
            Manifest.createRemoteSourceControlManifest(
                displayName: "aaa",
                url: "https://example.com/example.git",
                path: "/aaa",
                version: "1.3.0",
                products: [
                    ProductDescription(
                        name: "aaa",
                        type: .library(.automatic),
                        targets: ["aaa"]
                    )
                ],
                targets: [
                    TargetDescription(name: "aaa")
                ]
            )
        ],
        observabilityScope: observability.topScope
    )

    testDiagnostics(observability.diagnostics) { result in
        result.check(
            diagnostic: "error: 'zzz': product 'aaa' required by package 'zzz' target 'repro' not found. Did you mean '.product(name: \"aaa\", package: \"aaa\")'?",
            severity: .error
        )
    }
}

However, this test fails with the message "test_(): failed - No diagnostics left to check".
I would like to know how to solve this problem.

[kateinoigakukun]

@swift-ci test

[kateinoigakukun]

Thank you for your contribution!