Introduce manifest editing API for "add target dependency" #7552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
As a convenience for when we want to be able to add new target dependencies, introduce a manifest editing API that adds a new target dependency to an existing target in the manifest.
DougGregor
force-pushed
the
manifest-add-target-dependency
branch
from
64e4184 to
2a14c67
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
DougGregor
commented
May 13, 2024
|
@swift-ci please test |
|
@swift-ci please test Windows |
ahoppen
approved these changes
May 14, 2024
bnbarham
approved these changes
May 14, 2024
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…#7552) As a convenience for when we want to be able to add new target dependencies, introduce a manifest editing API that adds a new target dependency to an existing target in the manifest.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…#7552) As a convenience for when we want to be able to add new target dependencies, introduce a manifest editing API that adds a new target dependency to an existing target in the manifest.
bnbarham
pushed a commit
to bnbarham/swift-package-manager
that referenced
this pull request
May 18, 2024
shahmishal
pushed a commit
that referenced
this pull request
May 18, 2024
*Explanation*: I went through the last few months of PRs to make sure anything relevant is cherry-picked. Most of these are NFC but cherry-picking will help with conflicts. The main are: * Better error message - #7419 * Fix for visionOS for `--build-system xcode` - #7448 * Package registry fix - #7454 * Manifest editing API for adding target dependencies - #7552 * Various sendable annotations *Scope*: Package manifests/graphs with duplicate product/target names. *Risk*: Very low *Reviewed By*: Various, mostly @MaxDesiatov --------- Co-authored-by: Max Desiatov <[email protected]> Co-authored-by: k-kohey <[email protected]> Co-authored-by: miharu <[email protected]> Co-authored-by: Ryu <[email protected]> Co-authored-by: Philipp Wallrich <[email protected]> Co-authored-by: Boris Bügling <[email protected]> Co-authored-by: coffmark <[email protected]> Co-authored-by: Doug Gregor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a convenience for when we want to be able to add new target dependencies, introduce a manifest editing API that adds a new target dependency to an existing target in the manifest.